Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: File rotation text not updated after logging maxHistory changes #19386

Closed
Anden opened this issue Dec 17, 2019 · 1 comment
Closed

Docs: File rotation text not updated after logging maxHistory changes #19386

Anden opened this issue Dec 17, 2019 · 1 comment
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation update

Comments

@Anden
Copy link

Anden commented Dec 17, 2019

Hi, found a problem in the documentation:

https://docs.spring.io/spring-boot/docs/current/reference/html/spring-boot-features.html#boot-features-logging-file-output

Previously rotated files are archived indefinitely unless the logging.file.max-history property has been set.

Since #15875 logging.file.max-history is set to 7 by default, so above text should be updated.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 17, 2019
@bclozel bclozel added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 17, 2019
@bclozel bclozel added this to the 2.2.x milestone Dec 17, 2019
@snicoll
Copy link
Member

snicoll commented Dec 25, 2019

This should have done as part of #15875, Closing in favour of PR #19458

@snicoll snicoll closed this as completed Dec 25, 2019
@snicoll snicoll removed this from the 2.2.x milestone Dec 25, 2019
@snicoll snicoll added the status: superseded An issue that has been superseded by another label Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Anden @bclozel @snicoll @spring-projects-issues