Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration property for Reactor Netty shutdown quiet period #19607

Closed
bclozel opened this issue Jan 10, 2020 · 3 comments
Closed

Add configuration property for Reactor Netty shutdown quiet period #19607

bclozel opened this issue Jan 10, 2020 · 3 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@bclozel
Copy link
Member

bclozel commented Jan 10, 2020

As of reactor/reactor-netty#860, we can now configure the quiet period after the shutdown of the Reactor Netty web server.
We should consider using that API in NettyWebServer and even change the default value for a shorter one when devtools is present: right now, restarting the application with devtools inflicts the default quiet period on the user, making the feedback loop longer than necessary.

@bclozel bclozel added the type: enhancement A general enhancement label Jan 10, 2020
@bclozel bclozel added this to the 2.2.x milestone Jan 10, 2020
@Lacritz
Copy link

Lacritz commented Feb 16, 2020

Hi @bclozel,
is this issue currently still unassigned? I would like to contribute here - but currently not seeing the newly introduced api reflected in the current dependencies. Am i missing something?

@bclozel
Copy link
Member Author

bclozel commented Feb 17, 2020

@Lacritz we need to address spring-projects/spring-framework#24538 first.

@bclozel bclozel removed the type: enhancement A general enhancement label Apr 15, 2020
@bclozel bclozel removed this from the 2.2.x milestone Apr 15, 2020
@bclozel bclozel added the status: superseded An issue that has been superseded by another label Apr 15, 2020
@bclozel
Copy link
Member Author

bclozel commented Apr 15, 2020

This has been superseded by #4657

@bclozel bclozel closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

No branches or pull requests

2 participants