Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buildpack support #19698

Closed
13 of 14 tasks
philwebb opened this issue Jan 13, 2020 · 3 comments
Closed
13 of 14 tasks

Add buildpack support #19698

philwebb opened this issue Jan 13, 2020 · 3 comments
Labels
theme: kubernetes type: epic An issue tracking a large piece of work that will be split into smaller issues

Comments

@philwebb
Copy link
Member

philwebb commented Jan 13, 2020

Following on from #12545 we'd like to add buildpack support so that Docker images can be created easily from Maven/Gradle via a buildpack.

The following task need addressing:

@philwebb philwebb added this to the 2.3.x milestone Jan 13, 2020
@philwebb philwebb assigned philwebb and unassigned philwebb Jan 20, 2020
@leobut
Copy link

leobut commented Jan 28, 2020

I really love this feature and how it is coming along so far. Great work!
Just one question: Will it be possible to allow custom settings for the Docker image like for example additional ports or environment variables?

@snicoll
Copy link
Member

snicoll commented Jan 29, 2020

@ControlTheBit that's really something to do in the builder. A buildpack it defines can contribute anything to the docker image. For instance the JMX builder can contribute the relevant JVM properties to JAVA_OPTS if JMX support is required. This is controller by a flag (BP_JMX) that you can set as an env variable in the Maven or Gradle plugin.

You can also come chat with the community on Gitter if you have more questions.

@wilkinsona wilkinsona added type: epic An issue tracking a large piece of work that will be split into smaller issues and removed type: enhancement A general enhancement labels Mar 6, 2020
@philwebb philwebb removed this from the 2.3.x milestone Apr 11, 2020
@philwebb
Copy link
Member Author

I'm closing this one now since it's mostly complete. We'll deal with #20560 if we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: kubernetes type: epic An issue tracking a large piece of work that will be split into smaller issues
Projects
None yet
Development

No branches or pull requests

4 participants