Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate link checking for generated documentation #21035

Open
scottfrederick opened this issue Apr 20, 2020 · 4 comments
Open

Automate link checking for generated documentation #21035

scottfrederick opened this issue Apr 20, 2020 · 4 comments
Labels
type: task A general task

Comments

@scottfrederick
Copy link
Contributor

There have been a few issues lately with broken links in docs (e.g. #20818, #21019). We should investigate automated checking of links in generated or published docs.

@scottfrederick scottfrederick added the type: task A general task label Apr 20, 2020
@dreis2211
Copy link
Contributor

I used http://validator.w3.org/checklink today to find hopefully one last issue. Maybe you can take a look at that for inspiration and/or validation of results.

As you can see there are some URLs which are generally reachable via Browser, but not if you simply curl against them, e.g.:

curl -I https://redis.io
HTTP/1.1 404 Not Found
Server: nginx/1.10.2
Date: Wed, 22 Apr 2020 16:50:24 GMT
Content-Length: 3673
Connection: keep-alive

@wilkinsona
Copy link
Member

wilkinsona commented Apr 23, 2020

Interesting finding. Thanks, @dreis2211. Looks like redis.io changes behaviour based on the User-Agent. It 404s for HEAD requests too. It responds with a 200 for GET or HEAD if you spoof the user agent and pretend to be a browser.

@dreis2211
Copy link
Contributor

dreis2211 commented Apr 23, 2020

Yeah, there are some which are also behind HTTP Basic auth. My point being: Some URLs are false positives and require a bit more magic than others for an eventual tooling.

@philwebb philwebb added this to the General Backlog milestone Apr 23, 2020
@danielmenezesbr
Copy link

Istio.io [1] [2] uses html-proofer and linkinator to test rendered HTML files to make sure they're accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

5 participants