Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spring Ldap 2.3.3.RELEASE #21342

Closed
snicoll opened this issue May 6, 2020 · 3 comments
Closed

Upgrade to Spring Ldap 2.3.3.RELEASE #21342

snicoll opened this issue May 6, 2020 · 3 comments
Assignees
Labels
type: dependency-upgrade A dependency upgrade
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented May 6, 2020

No description provided.

@snicoll snicoll added the type: dependency-upgrade A dependency upgrade label May 6, 2020
@snicoll snicoll added this to the 2.1.14 milestone May 6, 2020
@snicoll snicoll changed the title Upgrade to Spring Ldap 2.3.2.RELEASE Upgrade to Spring Ldap 2.3.3.RELEASE May 6, 2020
@wilkinsona
Copy link
Member

wilkinsona commented May 6, 2020

This causes some test failures in LdapAutoConfigurationTests due to this change that was made to fix spring-projects/spring-ldap#473.

It looks like anonymousReadOnly on LdapProperties needs to become a Boolean as the default changes depending on whether or not there's a username (which is mapped to userDn).

@snicoll
Copy link
Member Author

snicoll commented May 7, 2020

There is that and there is the fact that userDn is initialized to an empty String by default (which means our defaults do not match that).

This change means essentially that the flag is now true by default without any extra configuration. I am not sure we should upgrade with the current arrangement.

@snicoll
Copy link
Member Author

snicoll commented May 7, 2020

This change means essentially that the flag is now true by default without any extra configuration.

I was wrong there since the code does a isEmtpy check so that empty string is treated the same as null. I've added a test to exercise the scenario where a username is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

2 participants