Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to enable liveness and readiness probes outside of a Kubernetes environment #21505

Closed
clojj opened this issue May 19, 2020 · 2 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@clojj
Copy link

clojj commented May 19, 2020

in a newly generated Sring Boot project with Release 2.3.0.RELEASE, including Web Reactive and Actuator, does not automatically provide liveness and readiness endpoints.

The docs don't suggest any additional configuration for these endpoints, as far as I understand.

boot log is

2020-05-19 16:46:44.781  INFO 3252 --- [           main] com.example.demo.DemoApplicationKt       : No active profile set, falling back to default profiles: default
2020-05-19 16:46:45.824  WARN 3252 --- [           main] ion$DefaultTemplateResolverConfiguration : Cannot find template location: classpath:/templates/ (please add some templates or check your Thymeleaf configuration)
2020-05-19 16:46:45.976  INFO 3252 --- [           main] o.s.b.a.e.web.EndpointLinksResolver      : Exposing 2 endpoint(s) beneath base path '/actuator'
2020-05-19 16:46:46.944  INFO 3252 --- [           main] o.s.b.web.embedded.netty.NettyWebServer  : Netty started on port(s): 8080
2020-05-19 16:46:46.955  INFO 3252 --- [           main] com.example.demo.DemoApplicationKt       : Started DemoApplicationKt in 2.462 seconds (JVM running for 2.797)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 19, 2020
@bclozel bclozel self-assigned this May 19, 2020
@bclozel bclozel added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels May 19, 2020
@bclozel bclozel added this to the 2.3.1 milestone May 19, 2020
@clojj
Copy link
Author

clojj commented May 19, 2020

just found the missing property from the blog post myself:

management.health.probes.enabled=true

@bclozel
Copy link
Member

bclozel commented May 19, 2020

Hi @clojj

This is a documentation bit that we've missed in this part. We've been iterating on this feature a few times and this part was left out unfortunately. I'll repurpose this issue as a documentation enhancement.

I see you've found the management.health.probes.enabled=true configuration property in the blog post. I'll add something in the " Kubernetes Probes" section to mention that probes are only enabled in a Kubernetes environement or if management.health.probes.enabled=true.

Thanks!

@wilkinsona wilkinsona changed the title hitting http://localhost:8080/actuator/health/readiness returns 404 Document how to enable liveness and readiness probes outside of a Kubernetes environment May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

3 participants