Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document deprecations of org.springframework.boot.loader.archive.Archive.iterator() #21695

Closed
wilkinsona opened this issue Jun 4, 2020 · 1 comment
Closed

Document deprecations of org.springframework.boot.loader.archive.Archive.iterator() #21695

wilkinsona opened this issue Jun 4, 2020 · 1 comment
Labels
type: documentation A documentation update
Milestone
2.3.1

Comments

@wilkinsona
Copy link
Member

org.springframework.boot.loader.archive.Archive.iterator() was deprecated in 2.3 but Archive implements Iterable<Archive.Entry> which defines the iterator() method. If we remove the deprecated method it'll become present in undeprecated form as it'll be inherited from Iterable. I think we either need to deprecate all three methods defined by Iterable so that Archive can stop extending it in the future or we need to undeprecate iterator().
@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Jun 4, 2020
@wilkinsona wilkinsona added this to the 2.3.x milestone Jun 4, 2020
@philwebb
Copy link
Member

philwebb commented Jun 4, 2020

My preference would be to deprecate all three.

@philwebb philwebb added type: task A general task type: documentation A documentation update and removed for: team-attention An issue we'd like other members of the team to review type: task A general task labels Jun 5, 2020
@philwebb philwebb changed the title Review deprecation of org.springframework.boot.loader.archive.Archive.iterator() Document deprecations of org.springframework.boot.loader.archive.Archive.iterator() Jun 8, 2020
@philwebb philwebb mentioned this issue Jun 8, 2020
Closed
@snicoll snicoll modified the milestones: 2.3.x, 2.3.1 Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.3.1
Development

No branches or pull requests
3 participants
@snicoll @philwebb @wilkinsona