Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to reflection-free configuration for infrastructure where bean definitions are created manually #22318

Closed
dsyer opened this issue Jul 13, 2020 · 1 comment
Closed

Switch to reflection-free configuration for infrastructure where bean definitions are created manually #22318

dsyer opened this issue Jul 13, 2020 · 1 comment
Assignees
@wilkinsona
Labels
theme: aot An issue related to Ahead-of-time processing type: task A general task
Milestone
2.4.0-M2

Comments

@dsyer
Copy link
Member

dsyer commented Jul 13, 2020 •
edited

There are quite a few "helper" beans, e.g. related to processing @ConfigurationProperties, and they all get manually registered as GenericBeanDefinitions with reflection-based instantiation strategies. Probably this is unnecessary (unless there are visibility issues, which also would need to be addressed if we change this). In the package "org.springframework.boot.context.properties" I see bean definitions registered for ConfigurationPropertiesBeanDefinitionValidator, ConfigurationPropertiesBindingPostProcessor, BoundConfigurationProperties, ConfigurationBeanFactoryMetadata, ConfigurationPropertiesBinder and ConfigurationPropertiesBinder$Factory, for instance. Searching for usage of GenericBeanDefinition and RootBeanDefinition will show up about the same number again in various places.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 13, 2020
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 13, 2020
@philwebb philwebb added this to the 2.4.x milestone Jul 13, 2020
@wilkinsona wilkinsona self-assigned this Jul 14, 2020
@wilkinsona wilkinsona modified the milestones: 2.4.x, 2.4.0-M2 Jul 14, 2020
@wilkinsona wilkinsona reopened this Jul 14, 2020
@wilkinsona wilkinsona changed the title Switch to reflection-free configuration for infrastructure where GenericBeanDefinition is used currently Switch to reflection-free configuration for infrastructure where bean definitions are created manually Jul 14, 2020
@wilkinsona wilkinsona reopened this Jul 14, 2020
@wilkinsona
Copy link
Member

Re-opening to take care of some RootBeanDefinitions too.

@wilkinsona wilkinsona added type: task A general task and removed type: enhancement A general enhancement labels Jul 15, 2020
@wilkinsona wilkinsona mentioned this issue Feb 25, 2021
Closed
@mbhave mbhave added the theme: aot An issue related to Ahead-of-time processing label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
theme: aot An issue related to Ahead-of-time processing type: task A general task
Projects
None yet
Milestone
2.4.0-M2
Development

No branches or pull requests
5 participants
@dsyer @philwebb @wilkinsona @mbhave @spring-projects-issues