Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigDataEnvironment doesn't register updated Binder #24669

Closed
philwebb opened this issue Jan 6, 2021 · 0 comments
Closed

ConfigDataEnvironment doesn't register updated Binder #24669

philwebb opened this issue Jan 6, 2021 · 0 comments
Assignees
Labels
Milestone

Comments

@philwebb
Copy link
Member

@philwebb philwebb commented Jan 6, 2021

https://github.com/spring-cloud/spring-cloud-core-tests/blob/master/configserver/src/test/java/demo/ConfigServerApplicationTests.java currently fails when it uses the Binder from the BootstrapContext. We should update the binder after the profiles have been set and return a version without BinderOption.FAIL_ON_BIND_TO_INACTIVE_SOURCE.

@philwebb philwebb self-assigned this Jan 6, 2021
@philwebb philwebb added the type: bug label Jan 6, 2021
@philwebb philwebb added this to the 2.4.x milestone Jan 6, 2021
@philwebb philwebb closed this in 5b126b0 Jan 6, 2021
@philwebb philwebb modified the milestones: 2.4.x, 2.4.2 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant