Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-boot-server-tests is no longer testing the embedded servlet containers' static resource support #25949

Closed
wilkinsona opened this issue Apr 9, 2021 · 0 comments
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

1342e49 added spring-webmvc to the classpath of the test application. Unfortunately, this had the unintended side-effect of causing Spring MVC's static resource support to be used rather than the embedded containers'. We need to remove spring-webmvc from the test application's classpath and find a different way to test the negative match for @ConditionalOnWarDeployment. It might be worth adding something that also check that Spring MVC hasn't been auto-configured so that we don't accidentally reintroduce the problem in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant