Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-boot-maven-plugin: support two different registries for builder and runImage when one of them is authenticated #26759

Closed
pgalache opened this issue Jun 4, 2021 · 1 comment
Labels
status: duplicate A duplicate of another issue

Comments

@pgalache
Copy link

pgalache commented Jun 4, 2021

Currently the spring-boot-maven-plugin requires that both builder and runImage registries are the same in case authentication has to be set (docker.builderRegistry parameters ), as the authentication is applied for both.

A reasonable use case is that one of the images needs to be customized, for example, to add an application specific runtime dependency. In that case, the runImage could extend the default runImage and probably would have to be pushed to an internal registry of the organization, which will require authentication. But still want to use the builder image from the community, which is in a public registry.

One possible approach would be copying the builder image to the internal registry but losing automatic updates or proxying from the internal registry to the community one, but it's not always allowed.

Allowing different authentication parameters for builder and runImage (docker.runImageRegistry) would solve this problem and give developers more flexibility.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 4, 2021
@pgalache pgalache closed this as completed Jun 4, 2021
@pgalache pgalache reopened this Jun 4, 2021
@scottfrederick
Copy link
Contributor

This is a duplicate of #24547.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants