Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch banner to use a Log #26

Closed
mdeinum opened this issue Aug 16, 2013 · 4 comments
Closed

Switch banner to use a Log #26

mdeinum opened this issue Aug 16, 2013 · 4 comments

Comments

@mdeinum
Copy link
Contributor

mdeinum commented Aug 16, 2013

Currently the Banner implementation uses a Printstream to write the log, it would be nice if the Banner would be printen (also) using a Log. That way it would appear in logfiles also, making it quite clear when an application started.

@philwebb
Copy link
Member

Unfortunately using the log file for output results in quite a mess due to all the timestamp/thread/class info that gets included.

We currently do log a 'Starting' message but I think I want to keep the banner under our control which unfortunately means leaving it out of the log

@btiernay
Copy link

@philwebb now that there is the Banner abstraction, would it be possible to make this configurable? I personally would like to have this in the logs as it clearly delineates the process boundary of multiple executions. The default should still be stdout however.

@philwebb
Copy link
Member

@btiernay It should be possible I think. I'll open a new issue.

@btiernay
Copy link

@philwebb Bootiful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants