Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AbstractRabbitListenerContainerFactoryConfigurer and its subclasses to take their required settings as constructor arguments #27311

Closed
wilkinsona opened this issue Jul 13, 2021 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

An AbstractRabbitListenerContainerFactoryConfigurer and its sub-classes require RabbitProperties to have been set but the MessageConverter and List<RabbitRetryTemplateCustomizer> are both optional and can be left unset. All three are configured via setter methods making it hard to distinguish between things that are required and things that are optional. It'd be good if RabbitProperties was a constructor parameter.

To do this in a backwards-compatible manner we'll have to keep the default constructors and add on that takes RabbitProperties alongside them. We'll also have to keep the setter, albeit in a deprecated form.

@wilkinsona wilkinsona added the type: enhancement A general enhancement label Jul 13, 2021
@wilkinsona wilkinsona added this to the 2.6.x milestone Jul 13, 2021
@wilkinsona wilkinsona self-assigned this Jul 13, 2021
@wilkinsona wilkinsona modified the milestones: 2.6.x, 2.6.0-M1 Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant