New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StartupInfoLogger should log version of more Spring project #27
Comments
I'm really interested in this feature, and I think it would be easy to implement (just ask some well-known packages what their version is, like in |
Dave, it is probably easier to just iterate over all spring-***.jar jars in the lib folder and read the MANFEST.MF Implementation-Version. Would need to check how that could work if Boot is not being ran from an fat jar. Do you want me to take a run at that? |
I agree that might be a valid approach (make an assumption about jar file names and locations). As long as it doesn't add anything to startup time I think we could do it. Feel free to contribute. |
Is this still an open issue? |
It is yes. There is an "open" icon on the top left. If you don't mind my asking, why do you ask? |
We discussed this recently. For some people, a VCS tag would be sufficient to tell them all they needed to know about their application. For others, details of all of the dependencies and their versions would be useful. The consensus seemed to be that collecting the dependencies and their versions was best done at build time. The information could, perhaps, then be exposed via a plugin to the /info endpoint. Logging it, as suggested in this issue, is another option. |
After some consideration we don't think this is such a good idea, it's hard to know where we'd stop. The |
Currently StartupInfoLoggerm only logs information on the Spring Boot and Spring Framework version. Would be nice if the versions of all used Spring portfolio products would be logged (Spring Batch, Spring Data (JPA), Spring Security etc.).
The text was updated successfully, but these errors were encountered: