Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartupInfoLogger should log version of more Spring project #27

Closed
mdeinum opened this issue Aug 16, 2013 · 7 comments
Closed

StartupInfoLogger should log version of more Spring project #27

mdeinum opened this issue Aug 16, 2013 · 7 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@mdeinum
Copy link
Contributor

mdeinum commented Aug 16, 2013

Currently StartupInfoLoggerm only logs information on the Spring Boot and Spring Framework version. Would be nice if the versions of all used Spring portfolio products would be logged (Spring Batch, Spring Data (JPA), Spring Security etc.).

@dsyer
Copy link
Member

dsyer commented Nov 17, 2013

I'm really interested in this feature, and I think it would be easy to implement (just ask some well-known packages what their version is, like in SpringVersion). Testing it and making sure that it is robust against changes on the classpath is potentially a big job - but maybe not, so if you want to try a pull request, try and make it extensible and provide some tests.

@cdupuis
Copy link
Contributor

cdupuis commented Nov 25, 2013

Dave, it is probably easier to just iterate over all spring-***.jar jars in the lib folder and read the MANFEST.MF Implementation-Version. Would need to check how that could work if Boot is not being ran from an fat jar.

Do you want me to take a run at that?

@dsyer
Copy link
Member

dsyer commented Nov 25, 2013

I agree that might be a valid approach (make an assumption about jar file names and locations). As long as it doesn't add anything to startup time I think we could do it. Feel free to contribute.

@trisberg trisberg added this to the 1.1.4 milestone Jul 3, 2014
@philwebb philwebb removed this from the 1.1.4 milestone Jul 3, 2014
@bhoomikatg
Copy link

Is this still an open issue?

@snicoll
Copy link
Member

snicoll commented Mar 11, 2015

It is yes. There is an "open" icon on the top left. If you don't mind my asking, why do you ask?

@wilkinsona
Copy link
Member

We discussed this recently. For some people, a VCS tag would be sufficient to tell them all they needed to know about their application. For others, details of all of the dependencies and their versions would be useful. The consensus seemed to be that collecting the dependencies and their versions was best done at build time. The information could, perhaps, then be exposed via a plugin to the /info endpoint. Logging it, as suggested in this issue, is another option.

@philwebb philwebb removed the icebox label Aug 30, 2016
@philwebb philwebb closed this as completed Feb 2, 2017
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed type: enhancement A general enhancement labels Feb 2, 2017
@philwebb
Copy link
Member

philwebb commented Feb 2, 2017

After some consideration we don't think this is such a good idea, it's hard to know where we'd stop. The /info endpoint + version control is our recommended solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants