Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove values from JavaVersion enum for Java versions less than 17 #29503

Closed
wilkinsona opened this issue Jan 20, 2022 · 2 comments
Closed

Remove values from JavaVersion enum for Java versions less than 17 #29503

wilkinsona opened this issue Jan 20, 2022 · 2 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

With the JDK 17 baseline, having constants for Java 16 and below is pointless as our JavaVersion class can only be loaded on a Java 17 or later VM.

@wilkinsona wilkinsona added this to the 3.0.x milestone Jan 20, 2022
@wilkinsona wilkinsona added the type: enhancement A general enhancement label Jan 20, 2022
@daixi98
Copy link

daixi98 commented Jan 20, 2022

Hi @wilkinsona, any suggestion on the OnJavaCondition class?

@Test
void boundsTests() {
	testBounds(Range.EQUAL_OR_NEWER, JavaVersion.NINE, JavaVersion.EIGHT, true);
	testBounds(Range.EQUAL_OR_NEWER, JavaVersion.EIGHT, JavaVersion.EIGHT, true);
	testBounds(Range.EQUAL_OR_NEWER, JavaVersion.EIGHT, JavaVersion.NINE, false);
	testBounds(Range.OLDER_THAN, JavaVersion.NINE, JavaVersion.EIGHT, false);
	testBounds(Range.OLDER_THAN, JavaVersion.EIGHT, JavaVersion.EIGHT, false);
	testBounds(Range.OLDER_THAN, JavaVersion.EIGHT, JavaVersion.NINE, true);
}

@wilkinsona
Copy link
Member Author

I think it'll be easiest to wait until we've added EIGHTEEN (#29524).

@wilkinsona wilkinsona added status: blocked An issue that's blocked on an external project change status: on-hold We can't start working on this issue yet and removed status: blocked An issue that's blocked on an external project change labels Jan 21, 2022
@wilkinsona wilkinsona self-assigned this Mar 9, 2022
@wilkinsona wilkinsona removed the status: on-hold We can't start working on this issue yet label Mar 9, 2022
@wilkinsona wilkinsona modified the milestones: 3.0.x, 3.0.0-M2 Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants