Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure FormattingConversionService in GraphQlAutoConfiguration #29638

Closed
bclozel opened this issue Feb 3, 2022 · 0 comments
Closed

Configure FormattingConversionService in GraphQlAutoConfiguration #29638

bclozel opened this issue Feb 3, 2022 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Feb 3, 2022

As of spring-projects/spring-graphql#271, the AnnotatedControllerConfigurer will not allow to set the ConversionService directly, but rather let developers register formatters to it.

We should update the GraphQL auto-configuration to expose this feature . Unlike Web MVC, there cannot be a web-specific ConversionService instance and given the transport-agnostic nature of GraphQL we should not apply the web-specific converters there. Instead we could apply the ApplicationConversionService formatters and/or open it for custom registration of formatters through a callback.

@bclozel bclozel added the type: enhancement A general enhancement label Feb 3, 2022
@bclozel bclozel added this to the 2.7.0-M3 milestone Feb 3, 2022
@bclozel bclozel self-assigned this Mar 8, 2022
@bclozel bclozel closed this as completed in bf79d6b Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant