Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework spring.mustache properties to make it clear which are Servlet-specific #30273

Closed
wilkinsona opened this issue Mar 17, 2022 · 0 comments
Closed
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

Split out from #28858.

The following properties are Servlet-specific but that's not apparent from their prefix:

spring.mustache.allow-request-override
spring.mustache.allow-session-override
spring.mustache.cache
spring.mustache.content-type
spring.mustache.expose-request-attributes
spring.mustache.expose-session-attributes
spring.mustache.expose-spring-macro-helpers

Each should be deprecated and a replacement with a spring.mustache.servlet.prefix introduced. This will mean that MustacheProperties can no longer extend AbstractTemplateViewResolverProperties. Once these changes are in place, we can tackle #28858 by introducing a reactive-specific property that configures the media types supported by a org.springframework.boot.web.reactive.result.view.MustacheViewResolver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant