Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit "enabled" properties for view technologies #32250

Open
bclozel opened this issue Sep 7, 2022 · 0 comments
Open

Revisit "enabled" properties for view technologies #32250

bclozel opened this issue Sep 7, 2022 · 0 comments
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Milestone
3.x

Comments

@bclozel
Copy link
Member

bclozel commented Sep 7, 2022

As seen in #32162, spring.${viewTechnology}.enabled properties do not disable entirely the auto-configuration, but rather controls the registration of the MVC/WebFlux component that resolves templates for web views.

This applies to Freemarker, Thymeleaf and Mustache (and possibly others).

We should revisit this situation and choose between:

  • renaming the properties to align them with the current behavior
  • consider changing the behavior

In other situations, we've tried not to link an *.enabled property with auto-configurations being applied.
@bclozel bclozel added type: enhancement A general enhancement status: pending-design-work Needs design work before any code can be developed labels Sep 7, 2022
@bclozel bclozel added this to the 3.x milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Projects
None yet
Milestone
3.x
Development

No branches or pull requests
1 participant
@bclozel