Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpringBootContextLoader prints banner twice when using a @ContextHierarchy #33079

Closed
philwebb opened this issue Nov 8, 2022 · 1 comment
Closed

SpringBootContextLoader prints banner twice when using a @ContextHierarchy #33079

philwebb opened this issue Nov 8, 2022 · 1 comment
Assignees
@wilkinsona
Labels
type: bug A general bug
Milestone
2.6.14

Comments

@philwebb
Copy link
Member

philwebb commented Nov 8, 2022

Run SpringBootTestContextHierarchyTests and you see the banner printed twice. We should disable it for child contexts or possibly all contexts.
@philwebb philwebb added the type: enhancement A general enhancement label Nov 8, 2022
@philwebb philwebb added this to the 3.0.x milestone Nov 8, 2022
@wilkinsona wilkinsona added type: bug A general bug and removed type: enhancement A general enhancement labels Nov 9, 2022
@wilkinsona wilkinsona modified the milestones: 3.0.x, 2.6.x Nov 18, 2022
@wilkinsona wilkinsona self-assigned this Nov 18, 2022
@wilkinsona wilkinsona mentioned this issue Nov 18, 2022
Closed
@wilkinsona wilkinsona modified the milestones: 2.6.x, 2.6.14 Nov 18, 2022
@wilkinsona
Copy link
Member

I've switched the banner off for child contexts but left it on for the root context. This aligns it with the behavior of SpringApplicationBuilder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: bug A general bug
Projects
None yet
Milestone
2.6.14
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona