New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micrometer trace HTTP request span propagation #33228
Comments
cc:/ @JoeWang1127 |
@marcingrzejszczak @jonatan-ivanov can you please take a look? |
Yes, the new mechanism is through the instrumented HTTP clients: it's not Brave who provides these details anymore but the instrumentation. What HTTP client are you using? Are you trying to instrument it on your own? |
The sample that's surfacing this issue is using At first, I thought that @meltsufin you 'll probably have to look into this, too, since I am out. |
We have a working sample for resttemplate: https://github.com/micrometer-metrics/micrometer-samples/ |
Hi @jonatan-ivanov, thanks for your advice. I modified our sample (in However, compared with |
There are a few issues with the sample:
If you mean |
Hi @jonatan-ivanov, thanks for your feedback, the |
We've noticed that child spans of HTTP requests were showing up as independent root traces after migrating Spring Cloud GCP to Spring Boot 3.0 (RC2).
In old Spring Cloud Sleuth,
HttpTracing
bean was enriched with HTTP request parsing. While in MicrometerBraveHttpRequestParser
exists, it does not seem to be instantiated or injected intoHttpTracing
bean in Spring Boot autoconfiguration. In fact,HttpTracing
bean configured in Spring Boot looks very minimalistic.Is there a new mechanism through which we should be extracting existing trace information from HTTP headers?
The text was updated successfully, but these errors were encountered: