Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create configuration property for common low cardinality KeyValues in Observations #33241

Closed
Tracked by #35776
bclozel opened this issue Nov 17, 2022 · 1 comment
Closed
Tracked by #35776
Assignees
Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Nov 17, 2022

Currently, Spring Boot automatically registers Metrics Tags for the management.metrics.tags.* configuration properties.
Such values are applied to all outgoing metrics, thanks to a MeterFilter.

We should consider deprecating this property and replacing it with a new management.observations.keyvalues.*. This would apply properties as low cardinality KeyValues for all outgoing Observations (so, not just Metrics). This can be applied using a ObservationFilter bean, in a similar fashion.

@bclozel bclozel added type: enhancement A general enhancement theme: observability Issues related to observability labels Nov 17, 2022
@bclozel bclozel added this to the 3.1.x milestone Nov 17, 2022
@scottfrederick scottfrederick modified the milestones: 3.1.x, 3.2.x May 16, 2023
@philwebb philwebb mentioned this issue Jun 7, 2023
31 tasks
@mhalbritter mhalbritter self-assigned this Jun 13, 2023
@mhalbritter mhalbritter modified the milestones: 3.2.x, 3.2.0-M1 Jun 13, 2023
@mhalbritter
Copy link
Contributor

I've deprecated management.metrics.tags.* and added a new property management.observations.key-values.*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants