Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a testAndDevelopmentOnly Gradle configuration #35436

Closed
philwebb opened this issue May 15, 2023 · 3 comments
Closed

Add a testAndDevelopmentOnly Gradle configuration #35436

philwebb opened this issue May 15, 2023 · 3 comments
Assignees
Labels
theme: containers Testcontainers and Docker Compose features type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

philwebb commented May 15, 2023

@RestartScope is useful when working with testcontainers but with gradle we usually recommend that devtools is added to the developmentOnly configuration. It looks like this means it isn't available for tests.

We can add a new testAndDevelopmentOnly configuration similar to JavaPluginAction.configureDevelopmentOnlyConfiguration where JavaPlugin.TEST_RUNTIME_CLASSPATH_CONFIGURATION_NAME extends from developmentOnly?

@philwebb philwebb added type: enhancement A general enhancement status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress and removed type: enhancement A general enhancement labels May 15, 2023
@mhalbritter
Copy link
Contributor

When we change this, we have to update the documentation, too.

@philwebb philwebb changed the title Consider including developmentOnly dependencies in testImplementation Add a testAndDevelopmentOnly Gradle configuration May 31, 2023
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels May 31, 2023
@philwebb philwebb added this to the 3.2.x milestone May 31, 2023
@wilkinsona wilkinsona added the theme: containers Testcontainers and Docker Compose features label Jun 2, 2023
@wilkinsona wilkinsona self-assigned this Sep 28, 2023
@wilkinsona wilkinsona modified the milestones: 3.2.x, 3.2.0-RC1 Sep 28, 2023
@candrews
Copy link
Contributor

When we change this, we have to update the documentation, too.

This change hasn't yet been made: https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#features.testcontainers.at-development-time.devtools

@wilkinsona
Copy link
Member

Thanks, @candrews. I've opened #38571.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: containers Testcontainers and Docker Compose features type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants