Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using Testcontainers at development time with @ServiceConnection on a @Bean method, describe when to use the name attribute and why #36071

Closed
wilkinsona opened this issue Jun 25, 2023 · 0 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Jun 25, 2023

See #36064 and in particular #36064 (comment) for background. When using Testcontainers at development time with @ServiceConnection on a @Bean method, there's an increased need to use the name attribute of @ServiceConnection as the container instance isn't available for us to call getDockerImageName() on it. We should document this, describing when to use the name attribute and explaining why it's necessary.

@wilkinsona wilkinsona added this to the 3.1.x milestone Jun 25, 2023
@wilkinsona wilkinsona added the type: documentation A documentation update label Jun 25, 2023
@scottfrederick scottfrederick changed the title When using Testcontainers are development time with @ServiceConnection on a @Bean method, describe when to use the name attribute and why When using Testcontainers at development time with @ServiceConnection on a @Bean method, describe when to use the name attribute and why Oct 23, 2023
@mhalbritter mhalbritter self-assigned this Nov 13, 2023
@mhalbritter mhalbritter modified the milestones: 3.1.x, 3.1.6 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants