Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail configuration property metadata processing when additional metadata has unexpected content #37597

Closed
wilkinsona opened this issue Sep 27, 2023 · 3 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Sep 27, 2023

Some additional metadata currently has no effect as it's malformed. For example #37596 is caused by a default value being declared within hints instead of properties. We should consider making such errors cause a build failure so that they can be caught early.

@wilkinsona wilkinsona added this to the 3.x milestone Sep 27, 2023
@wilkinsona wilkinsona added the type: enhancement A general enhancement label Sep 27, 2023
@wilkinsona
Copy link
Member Author

We could either do this in the annotation processor and it would benefit everyone (and potentially break some people's builds if, for some reason, they want to have custom content in the file) or we could do it in our own build as an addition to CheckAdditionalSpringConfigurationMetadata and it would only benefit us but wouldn't break anyone's build.

@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Sep 27, 2023
@philwebb
Copy link
Member

We discussed this today and we think that we should add this functionality to the annotation processor.

@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Sep 27, 2023
@mhalbritter mhalbritter modified the milestones: 3.x, 3.3.0-M1 Jan 9, 2024
@mhalbritter mhalbritter self-assigned this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants