Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-configure TypeDefinitionConfigurer beans for GraphQL apps #39118

Closed
bclozel opened this issue Jan 12, 2024 · 0 comments
Closed

Auto-configure TypeDefinitionConfigurer beans for GraphQL apps #39118

bclozel opened this issue Jan 12, 2024 · 0 comments
Assignees
@bclozel
Labels
type: enhancement A general enhancement
Milestone
3.3.0-M1

Comments

@bclozel
Copy link
Member

bclozel commented Jan 12, 2024 •
edited

Currently the GraphQL auto-configuration considers many beans for configuring the GraphQL infrastructure, like DataFetcherExceptionResolver, SubscriptionExceptionResolver, etc. The org.springframework.graphql.execution.GraphQlSource.Builder also allows for configuring a TypeDefinitionConfigurer.

Currently the auto-configuration is hard-coding a ConnectionTypeDefinitionConfigurer, we should allow for a custom TypeDefinitionConfigurer bean in addition to ConnectionTypeDefinitionConfigurer.
@bclozel bclozel added the type: enhancement A general enhancement label Jan 12, 2024
@bclozel bclozel added this to the 3.3.x milestone Jan 12, 2024
@bclozel bclozel self-assigned this Jan 12, 2024
@bclozel bclozel changed the title Auto-configure ConnectionTypeDefinitionConfigurer beans for GraphQL apps Auto-configure TypeDefinitionConfigurer bean for GraphQL apps Jan 15, 2024
@bclozel bclozel changed the title Auto-configure TypeDefinitionConfigurer bean for GraphQL apps Auto-configure TypeDefinitionConfigurer beans for GraphQL apps Jan 15, 2024
@wilkinsona wilkinsona modified the milestones: 3.3.x, 3.3.0-M1 Jan 15, 2024
@bclozel bclozel mentioned this issue Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.3.0-M1
Development

No branches or pull requests
2 participants
@bclozel @wilkinsona