Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration key spring.rabbitmq.template.json-trusted-packages #40459

Closed
quaff opened this issue Apr 22, 2024 · 3 comments
Closed

Add configuration key spring.rabbitmq.template.json-trusted-packages #40459

quaff opened this issue Apr 22, 2024 · 3 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@quaff
Copy link
Contributor

quaff commented Apr 22, 2024

If the key present, then construct Jackson2JsonMessageConverter instead of default SimpleMessageConverter.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 22, 2024
@philwebb philwebb changed the title Add configuration key spring.rabbitmq.template.json-trusted-packages Add configuration key spring.rabbitmq.template.json-trusted-packages Apr 22, 2024
@philwebb
Copy link
Member

I'm not sure we should add a property for this. I think it's a little confusing that setting json-trusted-packages would change the MessageConverter. I also think it's generally best if code related settings such as package names stay in code.

Let's see what the rest of the team things, but I think I'm in favor of declaring a Jackson2JsonMessageConverter @Bean for trusted packages.

@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Apr 22, 2024
@mhalbritter
Copy link
Contributor

I agree with Phil. Setting json-trusted-packages which behind the scenes switches the converter implementation is too much "magic" for me.

@philwebb
Copy link
Member

I think we have consensus. Thanks anyway for the suggestion @quaff.

@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Apr 22, 2024
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@quaff @philwebb @spring-projects-issues @mhalbritter