Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review auto-configuration that accepts both a URI and separate properties #41280

Open
wilkinsona opened this issue Jul 1, 2024 · 1 comment
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

As identified by #41231, we should review our auto-configuration in the places where it accepts both a URI and separate properties as there's the potential for some confusion and inconsistency.

Upon initial inspection, it would appear that the Neo4j auto-configuration ignores any user info in its URI and only uses the separate username and password properties for authentication. The Elasticsearch auto-configuration does things differently as it uses any user info in the configured URI(s) with the separate username and password being used as a fallback. Part of this is differences in the underlying services leaking out into Boot's properties but I think a review is still warranted as we should try to make things as consistent as possible and document any remaining inconsistencies.

@wilkinsona wilkinsona added type: task A general task for: team-meeting An issue we'd like to discuss as a team to make progress labels Jul 1, 2024
@philwebb philwebb modified the milestones: 3.3.x, 3.x Jul 3, 2024
@philwebb philwebb removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Jul 3, 2024
@facewise
Copy link
Contributor

facewise commented Aug 2, 2024

Truly agree with having consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

3 participants