You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In TomcatEmbeddedServletContainerFactory.configureSession(), a StandardManager object is created if this.manager is null. But it is not needed if isPersistSession() is false.
This superfluous creation has somewhat bad effect when another manager is needed for the context. For example, when configuring tomcat session clustering, a DeltaManager is needed instead of StandardManager. an application programmer can replace the manager by adding a TomcatContextCustomizer that's called later, but it was not needed on previous versions of Spring Boot (since the manager would be created automatically later) thus breaking compatibility.
On the first commit that's related this issue, it had been properly done - that is, a StandardManager is created only when isPersistSession() is true. But on a commit later, it was changed to current form. I think the first commit's code is better.
The text was updated successfully, but these errors were encountered:
In
TomcatEmbeddedServletContainerFactory.configureSession()
, aStandardManager
object is created ifthis.manager
isnull
. But it is not needed ifisPersistSession()
isfalse
.This superfluous creation has somewhat bad effect when another manager is needed for the context. For example, when configuring tomcat session clustering, a
DeltaManager
is needed instead ofStandardManager
. an application programmer can replace the manager by adding aTomcatContextCustomizer
that's called later, but it was not needed on previous versions of Spring Boot (since the manager would be created automatically later) thus breaking compatibility.On the first commit that's related this issue, it had been properly done - that is, a
StandardManager
is created only whenisPersistSession()
is true. But on a commit later, it was changed to current form. I think the first commit's code is better.The text was updated successfully, but these errors were encountered: