Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractRepositoryConfigurationSourceSupport needs updated to work with latest Spring Data JPA #58

Closed
jbrisbin opened this issue Sep 23, 2013 · 1 comment
Closed

AbstractRepositoryConfigurationSourceSupport needs updated to work with latest Spring Data JPA #58

jbrisbin opened this issue Sep 23, 2013 · 1 comment
Labels
type: enhancement A general enhancement

Comments

@jbrisbin
Copy link

When overriding the default versions included in Spring Boot for JPA integration, an exception is encountered because of the addition of an Environment to the Spring Data AnnotationRepositoryConfigurationSource CTOR. To fix this, we need to make AbstractRepositoryConfigurationSourceSupport EnvironmentAware and pass that to AnnotationRepositoryConfigurationSource's CTOR.

This is a breaking change with earlier versions of Spring Data.
odrotbohm added a commit to odrotbohm/spring-boot that referenced this issue Sep 23, 2013
@odrotbohm
spring-projects#58 - Upgraded Spring Data JPA dependencies to Babbage…
02bc95f 
… release train.

Adapted to changes in the API in Spring Data Commons which requires to pass in the current Environment into the AnnotationRepositoryConfigurationSource.
odrotbohm added a commit that referenced this issue Sep 24, 2013
@odrotbohm
#58 - Upgraded Spring Data JPA dependencies to Babbage release train.
604b906 
Adapted to changes in the API in Spring Data Commons which requires to pass in the current Environment into the AnnotationRepositoryConfigurationSource.
@dsyer
Copy link
Member

dsyer commented Sep 30, 2013

I think this is fixed (Ollie's change was merged).

@dsyer dsyer closed this as completed Sep 30, 2013
gigfork pushed a commit to boostrack/spring-boot that referenced this issue Apr 21, 2014
@odrotbohm
spring-projects#58 - Upgraded Spring Data JPA dependencies to Babbage…
917cd1a 
… release train.

Adapted to changes in the API in Spring Data Commons which requires to pass in the current Environment into the AnnotationRepositoryConfigurationSource.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrisbin @dsyer