Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't publish JUnit runners #7421

Closed
philwebb opened this issue Nov 19, 2016 · 8 comments
Closed

Don't publish JUnit runners #7421

philwebb opened this issue Nov 19, 2016 · 8 comments
Assignees
@snicoll
Labels
type: blocker An issue that is blocking us from releasing
Milestone
1.5.0 RC1

Comments

@philwebb
Copy link
Member

Should we publish the jar or not. If not we need to test during the RC1 release.
@philwebb philwebb added the type: blocker An issue that is blocking us from releasing label Nov 19, 2016
@philwebb philwebb added this to the 1.5.0 RC1 milestone Nov 19, 2016
@philwebb
Copy link
Member Author

See #7420 for context

@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Nov 19, 2016
@spencergibb
Copy link
Member

👍 for publish. IIRC, Spring Cloud copied it and then published it.

@wilkinsona
Copy link
Member

wilkinsona commented Nov 19, 2016 •
edited

I'd prefer that we didn't publish them so that we have the freedom to change them however and whenever we like

@snicoll
Copy link
Member

snicoll commented Nov 19, 2016

What Andy said.

@wilkinsona
Copy link
Member

Erring on the side of caution, I've updated the build plan so that spring-boot-junit-runners is no longer published. As a result, the latest snapshot that's available should be from 21/11: http://repo.spring.io/libs-snapshot/org/springframework/boot/spring-boot-junit-runners/1.5.0.BUILD-SNAPSHOT/

@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Nov 23, 2016
@philwebb philwebb reopened this Nov 23, 2016
@philwebb philwebb assigned philwebb and snicoll and unassigned philwebb Nov 23, 2016
@snicoll
Copy link
Member

snicoll commented Nov 24, 2016

Added an explicit note in the release checklist about this.

@snicoll snicoll closed this as completed Nov 24, 2016
@snicoll
Copy link
Member

snicoll commented Dec 1, 2016

We've decided to rename that to spring-boot-test-support

@snicoll snicoll reopened this Dec 1, 2016
@snicoll snicoll closed this as completed in ee72e78 Dec 1, 2016
@snicoll
Copy link
Member

snicoll commented Dec 1, 2016

Bamboo build plan and release check list updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: blocker An issue that is blocking us from releasing
Projects
None yet
Milestone
1.5.0 RC1
Development

No branches or pull requests
4 participants
@snicoll @philwebb @spencergibb @wilkinsona