Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SpringApplication.run(Object) with type safe variants #9170

Closed
philwebb opened this issue May 11, 2017 · 3 comments
Closed

Replace SpringApplication.run(Object) with type safe variants #9170

philwebb opened this issue May 11, 2017 · 3 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

The SpringApplication.run(Object) API isn't very friendly for Ceylon and it isn't typesafe so the IDE can't help with suggestions. See this twitter conversation for background.

In 2.0 we can replace it with overloaded versions and possibly consider dropping some of the more exotic versions.

@philwebb philwebb self-assigned this May 11, 2017
@philwebb philwebb added this to the 2.0.0.M1 milestone May 11, 2017
@wilkinsona
Copy link
Member

wilkinsona commented May 15, 2017

I wonder if we should add the new methods and deprecate SpringApplication.run(Object) in 1.5.x?

@philwebb
Copy link
Member Author

@wilkinsona After digging into this a bit I think we can simply the API quite a bit. If we make run take Class<?> arguments, and getSources() take String arguments most people can probably still do what they need.

I doubt the Resource and Pacakge variants are used that often so we can probably just drop those. I'm tempted to try this in M1 and see who complains.

@gavinking
Copy link

Thanks, this looks perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants