RelaxedDataBinder does not bind values that are only defined in environment variable style

[nebhale]

I'm attempting to map the value of the environment variable GITHUB_CLIENT_ID onto an @ConfigurationProperties class as defined below:

@ConfigurationProperties(name = "github", ignoreUnknownFields = false)
public final class GitHubProperties {

    private volatile Client client = new Client();

    public Client getClient() { return this.client; }
    public void setClient(Client client) { this.client = client; }

    public static class Client {

        private volatile String id = "";
        private volatile String secret = "";

        public String getId() { return this.id; }
        public void setId(String id) { this.id = id; }

        public String getSecret() { return this.secret; }
        public void setSecret(String secret) { this.secret = secret; }
    }

}

Currently, the value of the environment variable is not bound correctly. However, if I set the property in application.yml it does.

---
github:
  client:
    id: dummy-id

The weird thing is that the value that is bound is the value from the environment not from the application.yml file. I believe I've traced the bug to the RelaxedDataBinder.getProperyValuesForNamePrefix() method. The method attempts to find the candidate keys for bind, but does so by scanning for methods staring with <name>.. In my case it's looking for github. which doesn't exist until I create that key in the application.yml.

Once it's found the candidate key though, it seems to do the "relaxed" binding just fine.

I believe that a change needs to be made to use the "relaxed" key matching algorithm when searching for the candidate keys.