Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Repository.delete*(…) methods [DATACMNS-28] #510

Closed
spring-projects-issues opened this issue Apr 15, 2011 · 1 comment
Closed

Review Repository.delete*(…) methods [DATACMNS-28] #510

spring-projects-issues opened this issue Apr 15, 2011 · 1 comment
Assignees
@odrotbohm
Labels
in: repository Repositories abstraction status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Oliver Drotbohm opened DATACMNS-28 and commented

For finder methods the Repository interface uses findOne(…) methods to find single entities as well as findAll(…) to find multiple ones. On the delete(…) side of things we don't align to that convention. Should we refactor that to do so?

No further details from DATACMNS-28
@spring-projects-issues
Copy link
Author

Oliver Drotbohm commented

We finally decided not to change the

@spring-projects-issues spring-projects-issues added status: declined A suggestion or change that we don't feel we should currently apply in: repository Repositories abstraction type: enhancement A general enhancement labels Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: repository Repositories abstraction status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odrotbohm @spring-projects-issues