Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only index type possible for bulk inserts, causes error with data-streams #2089

Open
on-delete opened this issue Feb 17, 2022 · 8 comments
Open
Labels
type: enhancement A general enhancement

Comments

@on-delete
Copy link

Currently, if you do a saveAll, the IndexQuery is build with OpType INDEX. This causes an error if you want to use it with a data-stream, as only create actions are allowed. Is this somehow planned to be implemented, that you can configure the query type on bulk inserts?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 17, 2022
@sothawo sothawo added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 17, 2022
@sothawo
Copy link
Collaborator

sothawo commented Feb 17, 2022

currently it is not possible to set this. I change this issue to a feature request.

@on-delete
Copy link
Author

Hey @sothawo just wanted to check if this enhancement will be implemented soon? Any update would be appreciated.

@sothawo
Copy link
Collaborator

sothawo commented Feb 9, 2023

Spring Data Elasticsearch is a community driven project, there is no dedicated team anywhere working on it. I as a project lead manage / review contributions and as a maintainer add code myself. But I'm doing this in my spare time.
So issues have to wait until either someone from the community contributes or I find the time to implement them.

@on-delete
Copy link
Author

It was just a question for an update on this issue, no demand that it should be implemented soon. Sorry if that came off wrong at your side. We will, of course, wait for the implementation.

Thanks for your work, appreciate the effort!

@koshnarek
Copy link

just for the record... I stumbled upon this same point (datastream vs the missing optype on saving) and forked that part locally by adding the ability to get the optType from a parameter on Document annotation of a given Entity here

...which, obviously, I imagine not be appropriated... but would it be a good idea to allow it to be passed from the annotation to a more appropriate point on the code?

@sothawo
Copy link
Collaborator

sothawo commented Aug 16, 2023

Had no time yet to look intothis, but I think we should not add a detail like opType on the @Document annotation, but rather something like dataStream=true (having a default of false, and then at the different places where this information is needed - to set the op-type for example - refer to that value.

@koshnarek
Copy link

and something like that? main...koshnarek:spring-data-elasticsearch:main

@sothawo
Copy link
Collaborator

sothawo commented Jan 24, 2024

I,d rather put that as a property on the ElasticsearchPersistentEntity. I did not check yet, at what places this would be needed to be taken inot account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants