Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couchbase transactions example needs to be on 3.0.0-RC2 as 3.0.0 has … #649

Closed
wants to merge 1 commit into from
Closed

Couchbase transactions example needs to be on 3.0.0-RC2 as 3.0.0 has … #649

wants to merge 1 commit into from

Conversation

mikereiche
Copy link
Contributor

…reactor with a regression.

Also includes some improvements to sample.

Closes #648.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

…reactor with a regression.

Also includes some improvements to sample.

Closes #648.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 17, 2022
@@ -17,6 +17,7 @@
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-data-couchbase</artifactId>
<version>3.0.0-RC2</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot downgrade here as we will get conflicting dependencies. Users will generally see the same issue. Asking them to use a release candidate isn't an option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remove the <parent>, then this project will have no dependency on 3.0.0, only 3.0.0-RC2.

@mp911de
Copy link
Member

mp911de commented Apr 24, 2023

This pull request introduces changes everywhere with a description that doesn't reflect the actual change. We're upgrading to a newer Spring Boot version anyway. If you want to contribute a transactional example, then please submit a pull request introducing only that without touching all possible bits.

@mp911de mp911de closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants