DATAJDBC-395 - AbstractJdbcConfiguration no longer registers a bean of type DataAccessStrategy. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f type DataAccessStrategy. This avoids having multiple beans of that type in an ApplicationContext when a custom DataAccessStrategy needs to be provided.
odrotbohm
reviewed
Jul 11, 2019
| ObjectProvider<RelationResolver> relationResolverProvider, Optional<NamingStrategy> namingStrategy, | ||
| JdbcConverter jdbcConverter) { | ||
|
|
||
| RelationResolver relationResolver = relationResolverProvider.getIfAvailable(() -> dataAccessStrategy( // |
There was a problem hiding this comment.
Can we try to avoid these manual breaks in parameters lists? If a list exceeds the line length, we could rather prefer breaking right before the invocation instead:
relationResolverProvider //
.getIfAvailable(() -> …)
odrotbohm
approved these changes
Jul 11, 2019
|
|
||
| return new JdbcAggregateTemplate(publisher, context, converter, dataAccessStrategy); | ||
| return new JdbcAggregateTemplate( // |
There was a problem hiding this comment.
Same here. I think the single line reads way better than the ones broken out onto multiple ones.
| JdbcMappingContext context = jdbcMappingContext(namingStrategy); | ||
| return new DefaultDataAccessStrategy(new SqlGeneratorSource(context), context, jdbcConverter, operations); | ||
| defaultDataAccessStrategy = new DefaultDataAccessStrategy( // | ||
| new SqlGeneratorSource(context), // |
There was a problem hiding this comment.
Maybe extract into a local variable to keep the line shorter and avoid the additional manual breaks.
Avoid line breaks in parameter lists.
odrotbohm
approved these changes
Jul 11, 2019
odrotbohm
pushed a commit
that referenced
this pull request
Jul 11, 2019
…f type DataAccessStrategy. This avoids having multiple beans of that type in an ApplicationContext when a custom DataAccessStrategy needs to be provided. Original pull request: #160.
odrotbohm
pushed a commit
that referenced
this pull request
Jul 11, 2019
Avoid line breaks in parameter lists. Original pull request: #160.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids having multiple beans of that type in an ApplicationContext when a custom DataAccessStrategy needs to be provided.