Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation.skip(...) expects int but new SkipOperation(...) supports long [DATAMONGO-1521] #2432

Closed
spring-projects-issues opened this issue Nov 3, 2016 · 1 comment
Assignees
Labels
in: core type: bug

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Nov 3, 2016

Andre Schemschat opened DATAMONGO-1521 and commented

Currently the class SkipOperation takes an long as only parameter, the static factory method Aggregation.skip(…) takes an int. As the skip-operation seems to support long, should the static factory-method also use long?

public static SkipOperation skip(int elementsToSkip) {
		return new SkipOperation(elementsToSkip);
}

public SkipOperation(long skipCount) {
		Assert.isTrue(skipCount >= 0, "Skip count must not be negative!");
		this.skipCount = skipCount;
}

Affects: 1.9.4 (Hopper SR4)

Referenced from: commits 6a9823f, f011a9a, 4875f07

Backported to: 1.9.5 (Hopper SR5), 1.8.7 (Gosling SR7)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Nov 3, 2016

Oliver Drotbohm commented

I've added an overload taking a long and deprecated the other method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: bug
Projects
None yet
Development

No branches or pull requests

2 participants