enableTransactionSupport cause Redis Pool connections leak [DATAREDIS-823]

[spring-projects-issues]

GaoChao opened DATAREDIS-823 and commented

If set enableTransactionSupport=true and use RedisCache (Not use @Transactional Because 

we use @Cacheable)

RedisTemplate<Object, Object> template = new RedisTemplate<>();
template.setEnableTransactionSupport(true);

RedisCacheManager redisCacheManager = new RedisCacheManager(template);

When call org.springframework.data.redis.core.RedisConnectionUtils#releaseConnection

isConnectionTransactional return true TransactionSynchronizationManager.isCurrentTransactionReadOnly() return false,so both unbindConnection and conn.close() are not executed.

if (isConnectionTransactional(conn, factory)  
      && TransactionSynchronizationManager.isCurrentTransactionReadOnly()) {
   unbindConnection(factory);
} else if (!isConnectionTransactional(conn, factory)) {
   if (log.isDebugEnabled()) {
      log.debug("Closing Redis Connection");
   }
   conn.close();
}

The result is the connection is not released.

 

---

Affects: 1.8.11 (Ingalls SR11)

Attachments:

• SpringDataRedisDemo.zip (6.28 kB)

1 votes, 1 watchers

[spring-projects-issues]

Christoph Strobl commented

thanks for reporting.
Can you provide a bit insight why you use the tx feature on the template instead of the one available via RedisCacheManager#setTransactionAware?

[spring-projects-issues]

GaoChao commented

In the attachment project

When set spring.redis.transaction.enable=true in /src/test/resources/application.yml,the test may fail.(Somtimes it is passed.Ithink the reason is that the server reuse the same thread for diffrent request and the redis connection is binded to thread)

When set spring.redis.transaction.enable=false the test is passed

[mp911de]

That issue was addressed with #573 in version 2.5.0 M1. Marking it as duplicate.