Skip to content

LettuceReactiveKeyCommands.pExpireAt calls EXPIREAT command instead of PEXPIREAT [DATAREDIS-1031] #1591

@spring-projects-issues

Description

@spring-projects-issues

kaixuan.wu opened DATAREDIS-1031 and commented

@Override
public Flux<BooleanResponse<ExpireAtCommand>> pExpireAt(Publisher<ExpireAtCommand> commands) {

 return connection.execute(cmd -> Flux.from(commands).concatMap(command -> {

 Assert.notNull(command.getKey(), "Key must not be null!");
 Assert.notNull(command.getExpireAt(), "Expire at must not be null!");

 return cmd.expireat(command.getKey(), command.getExpireAt().toEpochMilli())
 .map(value -> new BooleanResponse<>(command, value));
 }));
}

i think it should be cmd.pexpireat 

default Mono<Boolean> pExpire(ByteBuffer key, Duration timeout) {

   Assert.notNull(key, "Key must not be null!");
   Assert.notNull(timeout, "Timeout must not be null!");

   return expire(Mono.just(new ExpireCommand(key, timeout))).next().map(BooleanResponse::getOutput);
}

 i think it should be cmd.pexpire

 


Referenced from: pull request #474, and commits 621164d, 1ae1acf, 11d5aff, 8c8ba7a, c19a0a6

Backported to: 2.1.11 (Lovelace SR11)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions