Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LettuceReactiveKeyCommands.pExpireAt calls EXPIREAT command instead of PEXPIREAT [DATAREDIS-1031] #1591

Closed
spring-projects-issues opened this issue Aug 29, 2019 · 0 comments
Assignees
Labels
in: lettuce Lettuce driver type: bug A general bug

Comments

@spring-projects-issues
Copy link

kaixuan.wu opened DATAREDIS-1031 and commented

@Override
public Flux<BooleanResponse<ExpireAtCommand>> pExpireAt(Publisher<ExpireAtCommand> commands) {

 return connection.execute(cmd -> Flux.from(commands).concatMap(command -> {

 Assert.notNull(command.getKey(), "Key must not be null!");
 Assert.notNull(command.getExpireAt(), "Expire at must not be null!");

 return cmd.expireat(command.getKey(), command.getExpireAt().toEpochMilli())
 .map(value -> new BooleanResponse<>(command, value));
 }));
}

i think it should be cmd.pexpireat 

default Mono<Boolean> pExpire(ByteBuffer key, Duration timeout) {

   Assert.notNull(key, "Key must not be null!");
   Assert.notNull(timeout, "Timeout must not be null!");

   return expire(Mono.just(new ExpireCommand(key, timeout))).next().map(BooleanResponse::getOutput);
}

 i think it should be cmd.pexpire

 


Referenced from: pull request #474, and commits 621164d, 1ae1acf, 11d5aff, 8c8ba7a, c19a0a6

Backported to: 2.1.11 (Lovelace SR11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: lettuce Lettuce driver type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants