Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Redis 6.0 ACL in Spring Data [DATAREDIS-1046] #1621

Closed
spring-projects-issues opened this issue Oct 10, 2019 · 5 comments
Closed
Assignees
Labels
in: core Issues in core support in: jedis Jedis driver in: lettuce Lettuce driver type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

tgrall opened DATAREDIS-1046 and commented

Redis 6.x will provide a new feature to support ACL, as documented here:

https://redis.io/topics/acl

Spring Data Redis should expose this to the application.

Related issue in client projects:

The following types should be extended by introducing a username property:

  • RedisStandaloneConfiguration
  • RedisSentinelConfiguration
  • RedisClusterConfiguration
  • RedisStaticMasterReplicaConfiguration
  • RedisSocketConfiguration

Issue Links:

Referenced from: pull request #558

2 votes, 6 watchers

@spring-projects-issues
Copy link
Author

Mark Paluch commented

From a library perspective, we should provide support for usernames to authenticate properly against Redis 6 in addition to password-only authentication.

Beyond that, it does not make sense to support administrative ACL commands as Spring Data Redis is intended for data interaction and not server administration

@spring-projects-issues
Copy link
Author

hradilf commented

Hi Mark Paluch, tgrall any idea where this can be available for Jedis? Thanks

@spring-projects-issues
Copy link
Author

Mark Paluch commented

Spring Data Redis depends on Jedis and you might want to track the related Jedis issue. Once Jedis provides this kind of functionality, we can adopt it here

@spring-projects-issues
Copy link
Author

hradilf commented

Hi Mark Paluch,
Jedis 3.3.0 has been released yesterday. It would be great to have ACL support in Spring.
https://github.com/xetorthio/jedis/releases/tag/jedis-3.3.0

@spring-projects-issues
Copy link
Author

Mark Paluch commented

Currently, we're beyond the second release candidate with Spring Data Redis 2.3 and heading towards the GA release in a few days. Redis 6 support will be available with Spring Data Redis 2.4 in late 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core support in: jedis Jedis driver in: lettuce Lettuce driver type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants