Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpringExpressionsParser doesn't work with newer version of ANTLR [SPR-5343] #10016

Closed
spring-projects-issues opened this issue Dec 7, 2008 · 5 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Kenny MacLeod opened SPR-5343 and commented

SpringExpressionsParser refers to the ruleMemo field in the org.antlr.runtime.BaseRecognizer subclass. This field was removed from BaseRecognizer in 2007

http://fisheye2.atlassian.com/browse/antlr/runtime/Java/src/org/antlr/runtime/BaseRecognizer.java?r1=3920&r2=3994

SpringExpressionsParser should be updated to work with the current version of ANTLR, if possible.


Affects: 3.0 M1

2 votes, 4 watchers

@spring-projects-issues
Copy link
Collaborator Author

Mike Yin commented

this also affects 3.0 M2

@spring-projects-issues
Copy link
Collaborator Author

Konstantin Shaposhnikov commented

Jython 2.5 uses Antlr 3.1 and Spring uses 3.0.1.
So spring can't be used together with jython because of that.

@spring-projects-issues
Copy link
Collaborator Author

Konstantin Shaposhnikov commented

Ideally Spring shouldn't require spring-expression library and its runtime dependencies unless you use expressions in the XML.

@spring-projects-issues
Copy link
Collaborator Author

Graham Zabel commented

ditto with JBoss drools 5. drools 5 uses antlr 3.1.1. Spring uses antlr 3.0.1. and they can't be run together.

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Note that recent Spring 3.0 RC1 snapshots already feature a reimplemented expression parser without any ANTLR dependency! This minimizes Spring core dependencies and removes the potential for ANTLR compatibility issues.

Juergen

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 M4 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants