Patch so that CronTriggerBean can take a start delay [SPR-5727]

[spring-projects-issues]

Robin Bramley opened SPR-5727 and commented

The SimpleTriggerBean supports a start delay, this patch adds the same feature to the CronTriggerBean so that you can defer the execution (e.g. to allow the system to stabilise at start-up).

---

Affects: 2.5.6, 3.0 M3

Attachments:

• crontrigger_delay.patch (1.88 kB)

Issue Links:

• SPRNET-1341 CronTriggerObject start delay support

Referenced from: commits 90652bf

[spring-projects-issues]

Robin Bramley commented

Can be tested with e.g.:

@Test
public void testAfterPropertiesSet() throws Exception {
    Date date0 = new Date();
    
    CronTriggerBean trigger0 = new CronTriggerBean();
    trigger0.setBeanName("beanName");
    trigger0.setStartDelay(0L);
    trigger0.afterPropertiesSet();
    assertNotNull(trigger0.getStartTime());
    
    // date compareTo: -1 < arg ; 0 = arg; 1 > arg
    Date date1 = trigger0.getStartTime();
    assertTrue(date0.compareTo(date1) >= 0);
}

@Test
public void testAfterPropertiesSetDelayedStart() throws Exception {
    Date date0 = new Date();
    CronTriggerBean trigger1 = new CronTriggerBean();
    trigger1.setBeanName("beanName");
    trigger1.setStartDelay(180000L);
    trigger1.afterPropertiesSet();
    assertNotNull(trigger1.getStartTime());
    // date compareTo: -1 < arg ; 0 = arg; 1 > arg
    Date date2 = trigger1.getStartTime();
    assertEquals(-1, date0.compareTo(date2));
}

[spring-projects-issues]

John Allen commented

For the use case mentioned, delay ing execution to allow the system to stabilise, the scheduler supports an overall startup delay.

[spring-projects-issues]

Robin Bramley commented

You're right that the SchedulerFactoryBean has a startupDelay property too (though specified in seconds) which would be a better fit for the example given above. This Jira/patch allows finer-grained delay on individual cron triggers as per the SimpleTriggerBean (could be viewed as being slightly against the cron 'fire at this point in time' grain)...