Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct compiler settings in spring-parent pom.xml to allow build with Maven [SPR-5735] #10405

Closed
spring-projects-issues opened this issue May 8, 2009 · 1 comment
Labels
type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Oliver Drotbohm opened SPR-5735 and commented

Trying to provide some extensions for Spring JDBC I tried to check out the module and integrate it into mavenized Eclipse (m2Eclipse). Currently most modules don't compile correctly due to the Maven compiler plugin being set to work with 1.5. The following settings will let it compile against Java 6:

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-compiler-plugin</artifactId>
  <configuration>
    <source>1.6</source>
    <target>1.5</target>
    <fork>true</fork>
    <compilerVersion>1.6</compilerVersion>
  </configuration>
</plugin>

Affects: 3.0 M3

Referenced from: commits 8364b61

@spring-projects-issues
Copy link
Collaborator Author

Mark Pollack commented

At the moment, we do not support building with maven, only "spring-build" as described here. http://blog.springsource.com/2009/03/03/building-spring-3/ One of the issues building with maven is thre are several external dependencies that are not in any public public repository.

I was going to resolve the issue as 'won't fix' but decided to at least make this change as you are using it inside eclipse and can therefore tweak the eclipse project to have it compile some modules and not others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant