Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange logic in ServletHandlerMethodInvoker.getModelAndView() [SPR-5768] #10438

Closed
spring-projects-issues opened this issue May 18, 2009 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Kenny MacLeod opened SPR-5768 and commented

In ServletHandlerMethodInvoker.getModelAndView(), the presense of a custom ModelAndViewResolver is checked for before the presense of @ResponseStatus on the handler method. If ModelAndViewResolver resolves, then getModelAndView() exits immediately, before the @ResponseStatus is checked and the status set accordingly.

I suggest that the order here be reversed, checking for the annotation first, since the annotation on the controller is more specific than the ModelAndViewResolver, which is context-wide. Additionally, this would allow REST applications to specify a custom ModelAndViewResolver for rendering POJO return values, whilst still using @ResponseStatus on the controller.


Affects: 3.0 M3

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 M4 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants