Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HttpMessageConverterExtractor top level class [SPR-5808] #10478

Closed
spring-projects-issues opened this issue Jun 5, 2009 · 4 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Oliver Drotbohm opened SPR-5808 and commented

I'm trying to implement ETag based caching with the M3's RestTemplate. Therefore I would like to use the template's default message conversion functionality in case I get a 200 result but rather access an already existing instance on a 304 e.g. Thus it would be cool if I could just subclass HttpMessageConverterExtractor, apply decision logik and trigger cache access or superclass extraction logic.


Affects: 3.0 M3

Referenced from: commits f7bf613, 59e41a2

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

I'll move the HttpMessageConverterExtractor to the top-level.

Also, I'd be interested in that ETag code. Can you share it with us?

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

Done

@spring-projects-issues
Copy link
Collaborator Author

Oliver Drotbohm commented

Of course. Just picked up the code and will get my hands dirty completing the stuff.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jun 10, 2009

Oliver Drotbohm commented

Have opened another ticket #10491 to address the caching idea. Had trouble attaching the source code, see comments over there.

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 M4 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants