Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom regex matching for @PathVariable [SPR-5812] #10482

Closed
spring-projects-issues opened this issue Jun 8, 2009 · 0 comments
Closed

Custom regex matching for @PathVariable [SPR-5812] #10482

spring-projects-issues opened this issue Jun 8, 2009 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Scott Andrews opened SPR-5812 and commented

The pattern for matching @PathVariable values in a URI is currently fixed. This makes it impossible for the request dispatcher to pick the intended mapping for complex mappings.

For example, the current infrastructure cannot distinguish between these two mappings:

{symbolicName}-{version}.jar
{symbolicName}-sources-{version}.jar

The "symbolicName" path variable is greedy, and the first mapping is selected for both values:

com.example-1.0.0.jar
com.example-sources-1.0.0.jar

The value of {symbolicName} will be "com.example" or "com.example-sources" respectively.

By specifying a custom regex pattern for the variable, a user can restrict the greediness of the first variable to the indented segment of the URI.

{symbolicName:[\w\.]+}-{version:[\w\.]+}.jar
{symbolicName:[\w\.]+}-sources-{version:[\w\.]+}.jar

It may be desirable to locate the regex in the @PathVariable annotation instead of in the @RequestMapping value.


Affects: 3.0 M3

Referenced from: commits ed98bf0

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 M4 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants