Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrameworkServlet does not need parent to be WebApplicationContext [SPR-6102] #10770

Closed
spring-projects-issues opened this issue Sep 11, 2009 · 1 comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Dave Syer opened SPR-6102 and commented

FrameworkServlet does not need its parent to be WebApplicationContext, but the signature of createWebApplicationContext() mandates it. It would be a small change, but quite helpful to people embedding a servlet application (e.g. in a test) to allow that method to accept a plain ApplicationContext (as it says it does in the Javadocs)


Affects: 3.0 M3

Referenced from: commits c3bf658, af0a529

@spring-projects-issues
Copy link
Collaborator Author

Costin Leau commented

Fixed. The method is now better aligned with FrameworkPortlet as well.

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 RC2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant