Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let StringArrayPropertyEditor trim resulting array values [SPR-6195] #10863

Closed
spring-projects-issues opened this issue Oct 6, 2009 · 2 comments
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Oliver Drotbohm opened SPR-6195 and commented

Currently the by default registered StringArrayPropertyEditor does not trim the String parts of the resulting array. This leads to subtle errors, e.g. if you configure the supported HTTP methods on an WebContentGenerator as follows:

..
<property name="supportedMethods" value="GET, POST, HEAD, DELETE" />
..

(note the spaces) this does not work, as the comparison with the actual request method is a hard equals. I think trimming the String is a sensible default.


Affects: 3.0 RC1

Referenced from: commits b250c65, 4be237d

@spring-projects-issues
Copy link
Collaborator Author

Oliver Drotbohm commented

Damn, forgot to set the ticket properties propertly. It's of course Spring Core and applies to all currently released versions I guess.

@spring-projects-issues
Copy link
Collaborator Author

Dave Syer commented

Fixed - default behaviour is to trim. Added constructors for reverting to old behaviour if needed.

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 RC2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant