Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompositeStringExpression doesn't use the ConversionService [SPR-6278] #10945

Closed
spring-projects-issues opened this issue Oct 27, 2009 · 1 comment
Closed

CompositeStringExpression doesn't use the ConversionService [SPR-6278] #10945

spring-projects-issues opened this issue Oct 27, 2009 · 1 comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
3.0 RC2

Comments

@spring-projects-issues
Copy link
Collaborator

Oliver Becker opened SPR-6278 and commented

Method org.springframework.expression.common.CompositeStringExpression.getValue(...) simply calls ObjectUtils.getDisplayString for creating the resulting string.
Since Spring provides a ConversionService, a proper toString TypeConverter should be used instead.
(if canConvert returns true, otherwise use getDisplayString)

Affects: 3.0 RC1

Referenced from: commits 3361de3
@spring-projects-issues
Copy link
Collaborator Author

Keith Donald commented

Changed to use Expression.getValue(..., String.class) flavors which delegates to TypeConverter underneath.

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 RC2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
3.0 RC2
Development

No branches or pull requests
1 participant
@spring-projects-issues