ResourceDatabasePopulator does not handle comments properly when ignoring failures [SPR-6345]

[spring-projects-issues]

Jaro Kuruc opened SPR-6345 and commented

Hi

I have a schema sql script which starts with a comment, followed by DROP and CREATE statements. I have configured DatabasePopulator to ignore DROP failures when initializing datasource.

In case of failure, ResourceDatabasePopulator tests on line 154 if statement starts with 'drop' substring and then based on ignoreFailedDrops setting ignores or rethrows the original SQLException. Because of the comment in my script, first statement starts with '-- ' substring, which then causes that the drop failure is not ignored as intended. The DatabasePopulator implementation should be fixed to handle comments better.

Thanks.

---

Affects: 3.0 RC2

Referenced from: commits 534f8a4

[spring-projects-issues]

Dave Syer commented

Fixed by stripping lines starting with "--" from the script before executing.